Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Unreal: launching on Linux #1672

Merged
merged 17 commits into from
Jul 7, 2021
Merged

Unreal: launching on Linux #1672

merged 17 commits into from
Jul 7, 2021

Conversation

antirotor
Copy link
Member

@antirotor antirotor commented Jun 9, 2021

This is fixing issues of launching Unreal on Linux.

🔙 Backport to 2.x - #1673

@antirotor antirotor added type: bug Something isn't working host: UE labels Jun 9, 2021
@antirotor antirotor self-assigned this Jun 9, 2021
@antirotor
Copy link
Member Author

Depends on #1674

@antirotor
Copy link
Member Author

This already includes #1679

@antirotor antirotor marked this pull request as ready for review June 22, 2021 14:54
@antirotor antirotor requested a review from iLLiCiTiT June 22, 2021 14:55
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried only on Windows (it's not only linux changing) and it works. I have to trust that it works on linux as that needs to be compiled which I'm not capable of. It works from 4.26 on. We should mention that in docs if it's not there.

@iLLiCiTiT
Copy link
Member

Can we add Unreal icon fix in this PR too?

@iLLiCiTiT
Copy link
Member

NOTE:
We could maybe move the project preparation from prelaunch hook move to Python script which is executed as different process. So it's separated from tray and we may be able to display that "something is happening" with progress bar?

@antirotor
Copy link
Member Author

Tried only on Windows (it's not only linux changing) and it works. I have to trust that it works on linux as that needs to be compiled which I'm not capable of. It works from 4.26 on. We should mention that in docs if it's not there.

We should even stop from trying to run it with older versions.

Can we add Unreal icon fix in this PR too?

Damn, I thought it is already in.

We could maybe move the project preparation from prelaunch hook move to Python script which is executed as different process. So it's separated from tray and we may be able to display that "something is happening" with progress bar?

Possibly, but where would you display such progress bar?

@iLLiCiTiT
Copy link
Member

Possibly, but where would you display such progress bar?

It is just an idea for future feature. Because if you'll run python script you can use Qt in it (like we do in nonpython hosts). But that may also cause other issues.

@antirotor antirotor requested a review from iLLiCiTiT June 29, 2021 14:54
@antirotor antirotor merged commit 79096aa into develop Jul 7, 2021
@mkolar mkolar deleted the bugfix/unreal-on-linux branch August 10, 2021 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: UE type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants